chore: retire ETL stage from unified pipeline#206
Merged
Conversation
The ETL stage in the unified pipeline DAG has had zero step consumers since PR #195. Remove the now-orphan configuration, loaders, DAG stage function, and supporting operator/enum entries: - clusters.yaml: drop the `etl` and `etl_literature` clusters plus the `step_job_properties.etl` block. - unified_pipeline.yaml: drop `etl_version` and the `etl_literature` step entry. - etl.conf: deleted (no longer loaded). - config/unified_pipeline.py: drop the `etl` AppConfig loader (and its PPP overlay), `etl_version`/`etl_jar_origin_uri`, the now-unused `jar_uri()` helper, and the `exts` map in `config_uri()`. - dags/unified_pipeline.py: drop the `etl_stage()` function, its call, and the imports that only it used (`ETLJobBuilder`, `CopyBlobOperator`, `to_hocon`). - operators/dataproc.py: delete `ETLJobBuilder`. - models/step.py: drop `UnifiedPipelineStage.ETL`. - operators/diff.py: refresh docstring examples that referenced the removed `etl_stage` task IDs.
DSuveges
approved these changes
Jun 8, 2026
DSuveges
left a comment
DSuveges
left a comment
Contributor
There was a problem hiding this comment.
Thank you for cleaning the orchestration from the scala etl specific logic and configuration.
- Removal of etl config
- Removal of etl steps from the unified pipeline
- Removal of etl/etl literature pipeline definitions.
- Removal of logic on how etl steps should be called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ETL stage in the unified pipeline DAG has had zero step consumers since #195. This PR retires the orphan configuration, loaders, DAG stage function, and supporting operator/enum entries.
Targets the
2606-public-releasebranch (PR #201) so it lands together with the public release work.Removed
clusters.yaml:etlandetl_literatureclusters, plus thestep_job_properties.etlblock.unified_pipeline.yaml:etl_versionand theetl_literaturestep entry.etl.conf: deleted entirely.config/unified_pipeline.py: theetlAppConfig loader (and its PPP overlay),etl_version/etl_jar_origin_uri, the now-unusedjar_uri()helper, and theextsmap inconfig_uri().dags/unified_pipeline.py: theetl_stage()function, its call site, and the imports that only it used (ETLJobBuilder,CopyBlobOperator,to_hocon).operators/dataproc.py:ETLJobBuilderclass.models/step.py:UnifiedPipelineStage.ETLenum entry.operators/diff.py: refreshed docstring examples that referenced the removedetl_stagetask IDs (now usepts_target).Net diff: +8 / -410 across 8 files.
Test plan
uv run ruff check src/ tests/— passesuv run ruff check .(excluding untracked locals) — passesuv run deptry .(excluding untracked locals) — passesuv run pytest tests/— 161 passed, 1 xfailedunified_pipelineDAG in Airflow to confirm it loads without the ETL stage