fix(dataproc): ensure staging dags run dataproc with default service account#212
Merged
Conversation
DSuveges
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is follow up on #205 which aligned the usage of dataproc operators across UnifiedPipeline and staging dags. The core change there was to remove duplicated codebase for creating, deleting and running cluster steps. This caused following change:
generate_dataproc_task_chain- function that is called by staging dags, now constructs aCustomClusterConfigdirectly from the caller's cluster_config dict. The CustomClusterConfig Pydantic model declares service_account with a module-level defaultIssue
Staging DAGs that do not explicitly include service_account in their config dict (see yaml configs) were silently inheriting this Airflow dev service account. The issue with that is the staging dags are meant to be run on the
open-targets-genetics-devproject instead of running under the Dataproc default compute service account. This caused IAM-related failures at cluster creation time when the Airflow SA lacked the permissions expected in the staging context.The same gap existed for internal_ip_only: staging DAGs omitting that key fell through to Pydantic's None default, whereas the intended baseline is False.
Implementations
Before unpacking cluster_config into CustomClusterConfig, inject safe sentinel defaults for the two fields via
dict.setdefault():setdefault is a no-op when the key is already present, so production DAGs that explicitly name a service account are unaffected.