This repository was archived by the owner on May 6, 2026. It is now read-only.
fix: correct binary path to include target/ directory#2
Merged
jrschumacher merged 2 commits intojrschumacher/sarajevofrom Jan 23, 2026
Merged
fix: correct binary path to include target/ directory#2jrschumacher merged 2 commits intojrschumacher/sarajevofrom
jrschumacher merged 2 commits intojrschumacher/sarajevofrom
Conversation
- Add GitHub Actions workflow that runs on PRs and pushes to main - Runs TypeScript type checking and Jest tests with coverage - Adjust coverage thresholds to target library code only (excludes integration scripts that are difficult to unit test) - Upload coverage reports to Codecov on PRs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The otdfctl release tarballs contain binaries inside a target/ directory (e.g., target/otdfctl-0.28.0-darwin-arm64), but the formula was looking for them at the root level. This fixes the installation path in the formula and updates the TypeScript generator to produce correct formulas. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the binary installation path in the Homebrew formula to correctly locate binaries inside the target/ directory within release tarballs. Updates both the formula and the TypeScript generator that produces it. All tests passing.