chore(ci): DSPX-850 - Add workflows to support LTS releases#260
chore(ci): DSPX-850 - Add workflows to support LTS releases#260
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces configurations for release-please to manage releases from the main branch and to support Long-Term Support (LTS) releases from release branches. The new release-please_main-branch.json correctly sets up minor version bumps for pre-1.0 features and includes updating a file. The modification to release-please_release-branches.json correctly changes the bumping strategy to patch versions for LTS branches, which is appropriate.
Summary of Findings
- Version consistency for LTS releases: Verify that
release-please_release-branches.jsonincludes anextra-filesentry to update the version incmdline/src/main/java/io/opentdf/platform/Command.java. This ensures the embedded SDK version is accurately updated for patch releases on LTS branches.
Merge Readiness
The changes in this pull request are well-structured and correctly implement the primary version bumping strategies for release-please on main and LTS branches. However, there's a key consideration regarding the completeness of version updates for LTS releases, specifically for a file. It is recommended to confirm this aspect and, if necessary, ensure the configuration in release-please_release-branches.json also updates this file before merging. Addressing this will ensure full consistency and accuracy in versioning across all release types. I am not authorized to approve pull requests; this feedback is intended to help improve the changes.
|
3 participants
No description provided.