Skip to content

chore(ci): DSPX- 2960 - bump Go toolchain to 1.25.9 to fix govulncheck reported vulnerabilities#3390

Merged
sievdokymov-virtru merged 2 commits intomainfrom
dspx-2960-bump-go-toolchain-1.25.9
Apr 28, 2026
Merged

chore(ci): DSPX- 2960 - bump Go toolchain to 1.25.9 to fix govulncheck reported vulnerabilities#3390
sievdokymov-virtru merged 2 commits intomainfrom
dspx-2960-bump-go-toolchain-1.25.9

Conversation

@sievdokymov-virtru
Copy link
Copy Markdown
Member

@sievdokymov-virtru sievdokymov-virtru commented Apr 24, 2026

Summary

Bumps the Go toolchain from go1.25.8 to go1.25.9 to resolve 4 standard library vulnerabilities flagged by govulncheck:

CVE Package Description
GO-2026-4947 crypto/x509 Unexpected work during chain building
GO-2026-4946 crypto/x509 Inefficient policy validation
GO-2026-4870 crypto/tls Unauthenticated TLS 1.3 KeyUpdate causes DoS
GO-2026-4865 html/template XSS via JsBraceDepth context tracking

No code changes required — this is a patch release with no breaking changes.

Vulns were initially reported in opentdf/otdfctl and PR submitted as opentdf/otdfctl#796

Test plan

  • target vulnerabilities are solved, govulncheck step passes in CI

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain to version 1.25.9 across all project modules and CI/CD infrastructure.

@sievdokymov-virtru sievdokymov-virtru requested review from a team as code owners April 24, 2026 10:01
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine maintenance update of the Go toolchain to the latest patch release. The primary objective is to resolve known security vulnerabilities within the Go standard library, ensuring the platform remains secure and compliant with current security standards. No functional code changes were required for this update.

Highlights

  • Go Toolchain Update: Updated the Go toolchain version from 1.25.8 to 1.25.9 across all project modules and the workspace file.
  • Security Remediation: Addressed four standard library vulnerabilities identified by govulncheck in crypto/x509, crypto/tls, and html/template.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/checks.yaml
    • .github/workflows/sonarcloud.yml
  • Ignored by pattern: protocol/**/* (1)
    • protocol/go/go.mod
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


The toolchain moves to a newer state, / To keep the code secure and great. / With vulnerabilities now gone, / The build process carries on.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added comp:ci Github Actions Work comp:sdk A software development kit, including library, for client applications and inter-service communicati comp:examples comp:lib:fixtures comp:lib:flattening comp:lib:ocrypto labels Apr 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

📝 Walkthrough

Walkthrough

Updates Go toolchain version from 1.25.8 to 1.25.9 across all module files and bumps GitHub Actions workflows to use Go 1.25.9.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/checks.yaml, .github/workflows/sonarcloud.yml
Updates Go version from 1.25.7 / 1.25.8 to 1.25.9 in govulncheck and test workflows.
Go Module Toolchain Updates
examples/go.mod, lib/fixtures/go.mod, lib/flattening/go.mod, lib/identifier/go.mod, lib/ocrypto/go.mod, otdfctl/go.mod, protocol/go/go.mod, sdk/go.mod, service/go.mod, test/integration/go.mod, tests-bdd/go.mod
Updates toolchain directive from go1.25.8 to go1.25.9 in all module files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

comp:ci, size/s

Suggested reviewers

  • c-r33d
  • elizabethhealy

Poem

🐰 A rabbit hops through version trees,
From 1.25.8 to .9 with ease,
Each module file gets the update right,
Go workflows shine in newest light!
Consistency hopped throughout the land! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: bumping Go toolchain to 1.25.9 to address govulncheck vulnerabilities.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dspx-2960-bump-go-toolchain-1.25.9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go toolchain version from 1.25.8 to 1.25.9 across multiple modules and the workspace file. Feedback indicates that the protocol/go/go.mod file was omitted from these updates and should be included to ensure consistency across the entire project.

Comment thread go.work
@github-actions
Copy link
Copy Markdown
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 144.127504ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 71.760434ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 345.858017ms
Throughput 289.14 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 33.585645019s
Average Latency 334.887788ms
Throughput 148.87 requests/second

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

  • tests-bdd

See the workflow run for details.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@jrschumacher jrschumacher added this pull request to the merge queue Apr 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 27, 2026
@sievdokymov-virtru sievdokymov-virtru added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit 1bf7cf8 Apr 28, 2026
72 of 76 checks passed
@sievdokymov-virtru sievdokymov-virtru deleted the dspx-2960-bump-go-toolchain-1.25.9 branch April 28, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:ci Github Actions Work comp:examples comp:lib:fixtures comp:lib:flattening comp:lib:ocrypto comp:sdk A software development kit, including library, for client applications and inter-service communicati size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants