fix(xtest): Use embedded platform otdfctl in auto#445
Conversation
When detect-otdfctl finds otdfctl/ in the platform checkout, PLATFORM_OTDFCTL_DIR
is set and guaranteed to exist. The auto-detect fallback was previously warning
and falling through to a standalone opentdf/otdfctl checkout, so platform PRs
that embed otdfctl (e.g. for PQC support) were not actually tested against their
own source. Now we set use_existing=true so the symlink step wires sdk/go/src/{tag}
to the platform checkout instead.
Older platform tags (e.g. v0.9.0) are unaffected: detect-otdfctl finds no otdfctl/
directory there, so PLATFORM_OTDFCTL_DIR stays empty and the elif condition is false.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions composite action ChangesGo Auto-Detect Reuse Logic
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the setup-cli-tool GitHub Action to enable automatic reuse of the platform-embedded otdfctl directory when the Go SDK is selected and a platform checkout is available. Previously, the action would fall back to a standalone checkout; this change optimizes the process by setting use_existing to true and needs_source to false when the directory is detected. I have no feedback to provide.
X-Test Results✅ go-main |
|
X-Test Results✅ js-main |
2 participants
When detect-otdfctl finds otdfctl/ in the platform checkout, PLATFORM_OTDFCTL_DIR
is set and guaranteed to exist. The auto-detect fallback was previously warning
and falling through to a standalone opentdf/otdfctl checkout, so platform PRs
that embed otdfctl (e.g. for PQC support) were not actually tested against their
own source. Now we set use_existing=true so the symlink step wires sdk/go/src/{tag}
to the platform checkout instead.
Older platform tags (e.g. v0.9.0) are unaffected: detect-otdfctl finds no otdfctl/
directory there, so PLATFORM_OTDFCTL_DIR stays empty and the elif condition is false.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Summary by CodeRabbit