-
Notifications
You must be signed in to change notification settings - Fork 2
feat(xtest): Allow selecting sdk versions for xtest #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmihalcik-virtru
wants to merge
13
commits into
main
Choose a base branch
from
DSPX-1115-sdkversions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cff554f
feat(xtest): version-qualified SDK params and per-version CI matrix
dmihalcik-virtru 1cc0356
fixup pyright
dmihalcik-virtru a55003f
Update xtest/conftest.py
dmihalcik-virtru 32bbf6b
Update xtest/tdfs.py
dmihalcik-virtru bce4da7
Update xtest/tdfs.py
dmihalcik-virtru 126062f
fix(xtest): use '@' instead of ':' as sdk specifier separator
dmihalcik-virtru e2fb79a
fix(xtest): harden sdk specifier validation and CI matrix guard
dmihalcik-virtru f6159d7
style: ruff format conftest.py
dmihalcik-virtru f60fc29
fixup legacy
dmihalcik-virtru 75a2f0b
feat(xtest): skip released-only SDK pairs on non-dispatch CI runs
dmihalcik-virtru 404c3ff
fix(xtest): don't skip released SDK pairs when testing a head platform
dmihalcik-virtru 0d199a3
fix(xtest): address PR review comments on sdk version detection and a…
dmihalcik-virtru 7bc0f72
style(xtest): enable ruff PERF rules and fix violations
dmihalcik-virtru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment here explaining this condition like in your PR description could be useful. 🤔