Improve the menu name for the default phonemizer#2151
Open
maiko3tattun wants to merge 1 commit into
Open
Conversation
Collaborator
|
Does not feel like an improvement to be honest... |
Contributor
Author
|
Many people who report that no sound is coming out are actually using the default phonemizer. We tell them to “change the phonemizer.” However, since the track header only displays “DEFAULT,” they don't know where to click. Alternatively, we can set the default phonemizer for the track to “None” and label it “Select Phonemizer” just like the singer. Do you prefer this approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the default phonemizer is selected, it was difficult to tell what this menu represented. This PR explicitly states that “the phonemizer is the default.”