Make all neaps packages ESM-only - #301
Merged
Merged
Conversation
The repo-wide tsdown config and @neaps/react's own config emitted dual CJS/ESM builds. The CJS entries of neaps, @neaps/tide-predictor, and @neaps/react loaded sibling packages with external require() calls, which breaks once @neaps/tide-database ships only ESM. Node 20.19+ / 22.12+ can still require() these packages via require(esm).
bkeepers
changed the title
@neaps/api
@neaps/cli
neaps
@neaps/react
@neaps/tide-predictor
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the whole repo ESM-only. The CJS builds of neaps, @neaps/tide-predictor, and @neaps/react loaded sibling packages with external
require()calls, which stops working once @neaps/tide-database ships only ESM (openwatersio/tide-database#103). Rather than bundling dependencies into CJS outputs, this drops them.The repo-wide
tsdown.config.jsand @neaps/react's own config now buildformat: ["esm"]only, and therequireconditions come out of each package'sexports. @neaps/api and @neaps/cli were already ESM-only. CommonJS consumers on Node 20.19+ / 22.12+ can stillrequire()these packages through Node's require(esm) support; older Node versions need the ESM entries.This intentionally does not bump the tide-database dependency. That lands separately once tide-database#103 is published.