Update @neaps/tide-database to 0.9 - #303
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps neaps and @neaps/cli to @neaps/tide-database 0.9, the release with the off-heap prediction-data pack (openwatersio/tide-database#103). Baseline heap drops from ~118 MB to ~36 MB since station data is read from the pack per station instead of being parsed into the heap at import. All 1,438 tests pass against 0.9.
Merge order
This must land after #293. @neaps/api currently bundles tide-database into its dist, which breaks with 0.9: the node build reads
generated/stations.packrelative toimport.meta.url, and the bundle doesn't carry the asset (verified: the built dist throws ENOENT). #293 makes tide-database an external dependency of @neaps/api, which resolves that; the api-side 0.9 bump is included there.