ci: cache GeoNames data to avoid re-downloading in tests - #117
Merged
Conversation
The geocode test downloads cities500.zip and admin1CodesASCII.txt from download.geonames.org on every CI run. downloadData() skips the fetch when the files already exist, so caching tmp/geonames across runs eliminates the repeated ~10MB download.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The geocode test pulls
cities500.zipandadmin1CodesASCII.txtfrom download.geonames.org on every CI run. The download helper already skips fetching when the files are on disk, so the only missing piece was persistingtmp/geonamesbetween runs.This adds an
actions/cachestep keyed ongeonames-v1. On a cache hit, the ~10MB download is skipped. Bump the version suffix in the key if the data ever needs refreshing.One caveat: Actions caches populate from the default branch, so the first real speedup lands after this merges to main and CI runs there once. After that, PRs read the cached copy.