keepalived-sync: fix mkdir permission denied in rsync.sh#28687
Open
willjayyyy wants to merge 1 commit intoopenwrt:masterfrom
Open
keepalived-sync: fix mkdir permission denied in rsync.sh#28687willjayyyy wants to merge 1 commit intoopenwrt:masterfrom
willjayyyy wants to merge 1 commit intoopenwrt:masterfrom
Conversation
The rsync.sh script uses sudo for rsync but not for mkdir. After the first sync, rsync -a preserves root ownership on directories under the sync target. Subsequent syncs fail at the mkdir step because the keepalived user cannot create subdirectories inside root-owned directories. Add sudo to the mkdir command to match the existing sudo rsync usage. Also update the sudoers configuration in the postinst script to permit /bin/mkdir in addition to /usr/bin/rsync. Fixes: openwrt#28565 Signed-off-by: willjayyyy <willjayyyy@users.noreply.github.com>
3 tasks
Member
|
Please add your real name and email to the SoB. Also, don't open new PRs, use the same PR for the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer: @feckert
The rsync.sh script uses sudo for rsync but not for mkdir. After the first sync, rsync -a preserves root ownership on directories under the sync target. Subsequent syncs fail at the mkdir step because the keepalived user cannot create subdirectories inside root-owned directories.
Add sudo to the mkdir command to match the existing sudo rsync usage.
Also update the sudoers configuration in the postinst script to permit /bin/mkdir in addition to /usr/bin/rsync.
Fixes: #28565