Skip to content

adds readiness and liveness probes to the worker process - #85

Closed
machisuji wants to merge 1 commit into
mainfrom
feature/worker-probes
Closed

adds readiness and liveness probes to the worker process#85
machisuji wants to merge 1 commit into
mainfrom
feature/worker-probes

Conversation

@machisuji

@machisuji machisuji commented Jan 22, 2024

Copy link
Copy Markdown
Member

Depends on opf/openproject#14625

I'm not sure how much sense it makes to add a readiness probe to the worker as that usually controls if traffic is routed to a container which does not apply in this case.

As for the liveness probe the question is how to do it. If the container is running then it will work off jobs. It's unlikely for the container to get stuck not doing anything. In that case it would probably just crash and be restarted anyway.

With the current liveness probe which is checked for unprocessed delayed jobs it might therefore not help to restart the containers if jobs start piling up. It might just be that there are not enough workers.

@changeset-bot

changeset-bot Bot commented Jan 22, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 00a3cc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@oliverguenther

Copy link
Copy Markdown
Member

@oliverguenther

Copy link
Copy Markdown
Member

superseded by #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants