Skip to content

[#68856] Move Project template selection to separate page#21048

Merged
HDinger merged 20 commits into
devfrom
feature/68856-project-create-separate-template-page
Nov 24, 2025
Merged

[#68856] Move Project template selection to separate page#21048
HDinger merged 20 commits into
devfrom
feature/68856-project-create-separate-template-page

Conversation

@myabc
Copy link
Copy Markdown
Contributor

@myabc myabc commented Nov 17, 2025 •
edited by dombesz
Loading

Ticket

https://community.openproject.org/wp/69074
Also adresses https://community.openproject.org/wp/69194

What are you trying to accomplish?

Seperates the Project creation form into two (or three) pages:

  1. the template selection
  2. filling in Project (built-in) attributes,
  3. required custom attributes (if they exist and no template was selected).

Further changes

  • Remove the Copy options from the project creation
  • Limit the width of project creation wizard pages and move the content to the center

Screenshots

Template selection (step 1)
Bildschirmfoto 2025-11-21 um 08 47 53

Built-in attributes (step 2)
Bildschirmfoto 2025-11-21 um 08 50 57

Required attributes (step 3)
Bildschirmfoto 2025-11-21 um 08 51 11

PIR
Bildschirmfoto 2025-11-21 um 08 47 43

What approach did you choose and why?

Merge checklist

  • Fix double-rendering of form
  • Removal of Copy Options
  • Added/updated tests
    • Update feature specs
    • Update form specs
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc myabc force-pushed the feature/68856-project-create-separate-template-page branch from ee6d401 to e98de43 Compare November 17, 2025 03:33
@myabc myabc added DO NOT MERGE ruby Pull requests that update Ruby code styling labels Nov 17, 2025
@myabc myabc mentioned this pull request Nov 17, 2025
Merged
3 tasks
@dombesz dombesz assigned dombesz and unassigned dombesz Nov 17, 2025
@myabc myabc added this to the 17.0.x milestone Nov 17, 2025
Base automatically changed from feature/68856-new-project-template-selector to dev November 18, 2025 11:51
@dombesz dombesz self-assigned this Nov 18, 2025
@dombesz dombesz force-pushed the feature/68856-project-create-separate-template-page branch from 88511b6 to c79f629 Compare November 18, 2025 17:26
dombesz and others added 10 commits November 19, 2025 12:49
@dombesz
Remove copy options when creating from template, store the step in a …
40a64f2 
…hidden field for validations, display the description field.
@dombesz
Add 3rd step to the project creation form.
00e93a6
@dombesz
Handle validation errors between the steps of the project creation wi…
9b842ed 
…zard.
@dombesz
Merge branch 'dev' into feature/68856-project-create-separate-templat…
3bba5bc 
…e-page
@dombesz
Simplify rendering step 2 and 3.
0d67d90
@HDinger
Add sub headings to the individual steps
0328e93
@HDinger
Abstract stepWizard footer to a generic component so that it can be r…
10cfda4 
…e-used for project creation
@HDinger
Switch from inheritance to using slots and calling the component dire…
1d81828 
…ctly
@dombesz
Move the total_step method from the ProjectsController to the Project…
06a7b14 
…CreationFooterComponent.
@HDinger
Extract step_wizard page layout to be able to re-use it
41dcbca
@dombesz dombesz force-pushed the feature/68856-project-create-separate-template-page branch from ab52aa6 to a8f5b39 Compare November 21, 2025 18:31
myabc
myabc commented Nov 21, 2025
View reviewed changes
Comment thread app/components/step_wizard/footer_component.rb
Comment on lines +38 to +40
render(Primer::Beta::ProgressBar.new(**progress_bar_args)) do |progress_bar|
progress_bar.with_item(percentage: progress_percentage)
end
Copy link
Copy Markdown
Contributor Author

@myabc myabc Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't call render from a slot definition. render will be called when the slot is called in the template.

myabc
myabc commented Nov 21, 2025
View reviewed changes
Comment thread app/components/step_wizard/footer_component.rb
myabc
myabc commented Nov 21, 2025
View reviewed changes
Comment thread app/components/step_wizard/page_layout_component.rb
myabc
myabc commented Nov 21, 2025
View reviewed changes
Comment thread app/components/step_wizard/page_layout_component.rb
@dombesz dombesz force-pushed the feature/68856-project-create-separate-template-page branch from d6505a6 to 86bae18 Compare November 22, 2025 10:47
@dombesz dombesz force-pushed the feature/68856-project-create-separate-template-page branch from 86bae18 to 0a26b4a Compare November 22, 2025 12:51
@HDinger HDinger marked this pull request as ready for review November 24, 2025 09:37
@HDinger HDinger merged commit df0914d into dev Nov 24, 2025
18 of 19 checks passed
@HDinger HDinger deleted the feature/68856-project-create-separate-template-page branch November 24, 2025 09:37
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@dombesz dombesz

Labels

feature ruby Pull requests that update Ruby code styling

Milestone

17.0.x

Development

Successfully merging this pull request may close these issues.

3 participants

@myabc @dombesz @HDinger