Bump CKEditor to 48.0#22837
Conversation
oliverguenther
force-pushed
the
bump/ckeditor
branch
from
a619bc3 to
51f3a55
Compare
oliverguenther
force-pushed
the
bump/ckeditor
branch
6 times, most recently
from
720b096 to
b76e7e5
Compare
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| await import(/* webpackChunkName: "ckeditor" */ 'core-vendor/ckeditor/ckeditor'); | ||
| const loadEditorScript = import(/* webpackChunkName: "ckeditor" */ 'core-vendor/ckeditor/ckeditor'); |
There was a problem hiding this comment.
nitpick, but /* webpackChunkName: "ckeditor" */ can be removed now. esbuild ignores.
| */ | ||
| private async load():Promise<void> { | ||
| // untyped module cannot be dynamically imported | ||
| // untyped modules cannot be dynamically imported |
There was a problem hiding this comment.
btw, this typing can/should be fixed eventually: https://community.openproject.org/wp/72830
(I started work on opf/commonmark-ckeditor-build#109 a while back)
|
@oliverguenther it looks like the text size and typeface is different (16px Helvetica vs 14px System), at least when editing a description on the work packages full view:
Also noticeable when inplace editing project descriptions on the Overview page: (cc @HDinger) 
Not sure if this is intentional or desired? |
Or because we're bundling styles that we weren't before - on with a different load order? |
myabc
left a comment
myabc
left a comment
There was a problem hiding this comment.
Apart from the text style changes, this seems to work as expected. 👍🏻 I manually tested the CodeMirror integration and that works well.
(with regards to CodeMirror, I began an attempt at upgrading to CodeMirror 6 last year - #19566. The API and internal event model is substantially different, but I did get the basics working)
There was a problem hiding this comment.
👍
I could not find any regression; all works as expected, including the PDF-related features like page-break.
Like Alex mentioned, the default CSS changed, so the font size and font family are different now.
The changes come from
and
f I change them to
--ck-content-font-family: inherit;
--ck-content-font-size: inherit;
The old values seem to be used again.
Deploying openproject with ⚡ PullPreview
|
oliverguenther
force-pushed
the
bump/ckeditor
branch
from
b76e7e5 to
1b21e80
Compare
oliverguenther
force-pushed
the
bump/ckeditor
branch
from
1b21e80 to
93034bc
Compare
3 participants
Related: opf/commonmark-ckeditor-build#111
https://community.openproject.org/projects/openproject/work_packages/74158/activity