Skip to content

Use project specific checking for custom field visibility in journals#23250

Closed
oliverguenther wants to merge 2 commits into
fix/journable-visibilityfrom
chore/easier-custom-field-visibility-check
Closed

Use project specific checking for custom field visibility in journals#23250
oliverguenther wants to merge 2 commits into
fix/journable-visibilityfrom
chore/easier-custom-field-visibility-check

Conversation

@oliverguenther
Copy link
Copy Markdown
Member

@oliverguenther oliverguenther commented May 18, 2026

  • Added visible?(usr = User.current, project: nil) delegating to self.class.visible(usr).exists?(id: id). Uses STI so the correct subclass scope is invoked automatically.
  • JournalsController: use a custom_field.visible? method instead of trying to solve visibility in the journals controller.

@oliverguenther oliverguenther force-pushed the chore/easier-custom-field-visibility-check branch from 79fcada to 552962d Compare May 18, 2026 11:36
@oliverguenther oliverguenther force-pushed the chore/easier-custom-field-visibility-check branch from 552962d to 81a9469 Compare May 18, 2026 11:39
@oliverguenther oliverguenther requested review from dombesz, toy and ulferts and removed request for ulferts May 18, 2026 11:39
@oliverguenther oliverguenther force-pushed the fix/journable-visibility branch from 2840443 to 3fcdc89 Compare May 19, 2026 07:21
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@toy toy Awaiting requested review from toy

@dombesz dombesz Awaiting requested review from dombesz

@ulferts ulferts Awaiting requested review from ulferts

Assignees

No one assigned

Labels

maintenance needs review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oliverguenther