[75226] Update XWiki auth integration#23321
Conversation
Remove outdated code, since now we can use the parent OAuth.
shiroginne
changed the title
how to overcome the error for the `with_trailing_action_clipboard_copy_button` in case if user will delete the data
Remove copy button as it doesn't work with validation errors
Add the provider type to the name of the provider
| class User < BaseQuery | ||
| def call(auth_strategy:) | ||
| url = "#{provider.url.chomp('/')}/rest/" | ||
| url = "#{provider.url.chomp('/')}/rest/wikis/xwiki/user" |
There was a problem hiding this comment.
This is the new user rest endpoint, more user data could be fetcher from this endpoint if we ever need it
| provider_oauth: XWiki OAuth | ||
| provider_oauth_description: Allow OpenProject to access XWiki data using OAuth. A client ID is automatically generated to identify OpenProject to XWiki — no manual configuration is needed on the XWiki side. | ||
| provider_oauth: Wiki OAuth | ||
| provider_oauth_description: Allow OpenProject to access XWiki data using OAuth. A client ID and client secret have been pre-generated for you — copy them along with the redirect URI into your XWiki OIDC client registration. You can change the client ID and secret if needed. |
There was a problem hiding this comment.
@dominic-braeunlein will provide better text here 😄
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
| end | ||
|
|
||
| page.with_sidebar(col_placement: :end, row_placement: :start) do | ||
| page.with_sidebar(col_placement: :end, row_placement: :end) do |
There was a problem hiding this comment.
Thanks for fixing this. I wanted to complain that we use row_placement: :start in storages, but that's a lie.
I must have misremembered this.
| oauth_application_details_html: The client secret value will not be accessible again after you close this window. Please copy these values into the [XWiki OpenProject Integration settings](xwiki_admin_link). | ||
| provider_types: | ||
| xwiki: | ||
| name: XWiki |
There was a problem hiding this comment.
I was surprised to see a separate translation for this, because activerecord.models.wikis/xwiki_provider exists (accessible through XWikiProvider.model_name.human).
However, there we translate it as "XWiki provider". I am wondering whether we should have separate translations or whether we could (for example) translate the model as "XWiki" everywhere.
There was a problem hiding this comment.
Ok, I've moved to model_name.human, but it shows "provider" in the translation, so we need just a provider name in those places:
I'd say we could keep different translations 🤔 in case if we'll rename the model name to just a provider name (dropping "provider"), we could have another round of discussions 😅 we could have one after the first part of the integration would be finished
| oauth_configuration: OAuth configuration | ||
| url_caption: Please add the host address of your wiki platform including the https://. It should not be longer than 255 characters. | ||
| xwiki_instance: XWiki Instance | ||
| xwiki_instance: Wiki Provider |
There was a problem hiding this comment.
I have to admit that I don't understand this translation string anymore.
The I18n key is wikis.admin.wiki_providers.xwiki_instance and we translate it with Wiki Provider?
This doesn't click with me. Also noteworthy that this translation could already be obtained through Wikis::Provider.model_name.human.
There was a problem hiding this comment.
Lazy translation 😓 we started with instance and now decided on provider, the translation was updated, but not the keys. I'll update the keys to _provider + drop unused ones
Co-authored-by: Jan Sandbrink <j.sandbrink@openproject.com>
Co-authored-by: Jan Sandbrink <j.sandbrink@openproject.com>
from `instance` to `provider`
2 participants
Ticket
75226
Update the OAuth registration for XWiki because the client registration has been added.
Update the UI/UX of the Wiki provider.
Screenshots
Merge checklist