Skip to content

cleanup erb #23360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toy merged 1 commit into from
May 26, 2026
Merged

cleanup erb #23360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 46 additions & 44 deletions modules/backlogs/app/components/backlogs/bucket_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,50 +28,52 @@ See COPYRIGHT and LICENSE files for more details.
++# %>

<%= component_wrapper(tag: :section) do %>
<%= render(
Backlogs::WorkPackageCardListComponent.new(
work_packages:,
project:,
container: backlog_bucket,
drag_and_drop: {
target_id: "backlog_bucket:#{backlog_bucket.id}",
allowed_drag_type: "story"
},
params: all_backlogs_params,
current_user:,
test_selector: "backlog-bucket-#{backlog_bucket.id}"
)
) do |list| %>
<% list.with_header(title: backlog_bucket.name) do |header| %>
<% if show_menu? %>
<% header.with_menu(button_aria_label: t(".label_actions")) do |menu| %>
<% with_item_group(menu) do %>
<% menu.with_item(
id: dom_target(backlog_bucket, :menu, :edit_backlog_bucket),
label: t(".action_menu.edit_backlog_bucket"),
href: edit_dialog_project_backlogs_backlog_bucket_path(project, backlog_bucket, all_backlogs_params),
content_arguments: { data: { controller: "async-dialog" } }
) do |item| %>
<% item.with_leading_visual_icon(icon: :pencil) %>
<% end %>
<%=
render(
Backlogs::WorkPackageCardListComponent.new(
work_packages:,
project:,
container: backlog_bucket,
drag_and_drop: {
target_id: "backlog_bucket:#{backlog_bucket.id}",
allowed_drag_type: "story"
},
params: all_backlogs_params,
current_user:,
test_selector: "backlog-bucket-#{backlog_bucket.id}"
)
) do |list|
list.with_header(title: backlog_bucket.name) do |header|
if show_menu?
header.with_menu(button_aria_label: t(".label_actions")) do |menu|
with_item_group(menu) do
menu.with_item(
id: dom_target(backlog_bucket, :menu, :edit_backlog_bucket),
label: t(".action_menu.edit_backlog_bucket"),
href: edit_dialog_project_backlogs_backlog_bucket_path(project, backlog_bucket, all_backlogs_params),
content_arguments: { data: { controller: "async-dialog" } }
) do |item|
item.with_leading_visual_icon(icon: :pencil)
end

<% menu.with_item(
id: dom_target(backlog_bucket, :menu, :delete_backlog_bucket),
label: t(".action_menu.delete_backlog_bucket"),
scheme: :danger,
href: destroy_dialog_project_backlogs_backlog_bucket_path(project, backlog_bucket, all_backlogs_params),
content_arguments: { data: { controller: "async-dialog" } }
) do |item| %>
<% item.with_leading_visual_icon(icon: :trash) %>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
menu.with_item(
id: dom_target(backlog_bucket, :menu, :delete_backlog_bucket),
label: t(".action_menu.delete_backlog_bucket"),
scheme: :danger,
href: destroy_dialog_project_backlogs_backlog_bucket_path(project, backlog_bucket, all_backlogs_params),
content_arguments: { data: { controller: "async-dialog" } }
) do |item|
item.with_leading_visual_icon(icon: :trash)
end
end
end
end
end

<% list.with_empty_state(
title: t(".blankslate_title"),
description: t(".blankslate_description")
) %>
<% end %>
list.with_empty_state(
title: t(".blankslate_title"),
description: t(".blankslate_description")
)
end
%>
<% end %>
117 changes: 59 additions & 58 deletions modules/backlogs/app/components/backlogs/inbox_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,65 +28,66 @@ See COPYRIGHT and LICENSE files for more details.
++# %>

<%= component_wrapper(tag: :section) do %>
<% inbox_container = dom_target(:inbox, project) %>
<%= render(
OpenProject::Common::BorderBoxListComponent.new(
container: inbox_container,
current_user:,
interactive: true,
scheme: :transparent,
padding: :condensed,
header_padding: :default,
test_selector: "backlog-inbox",
data: {
generic_drag_and_drop_target: "container",
target_container_accessor: ":scope > ul",
target_id: "inbox",
target_allowed_drag_type: "story"
}
)
) do |list| %>
<% list.with_header(title: t(".title"), count: work_packages.size, title_arguments: { font_size: 4 }) %>
<%=
render(
OpenProject::Common::BorderBoxListComponent.new(
container: dom_target(:inbox, project),
current_user:,
interactive: true,
scheme: :transparent,
padding: :condensed,
header_padding: :default,
test_selector: "backlog-inbox",
data: {
generic_drag_and_drop_target: "container",
target_container_accessor: ":scope > ul",
target_id: "inbox",
target_allowed_drag_type: "story"
}
)
) do |list|
list.with_header(title: t(".title"), count: work_packages.size, title_arguments: { font_size: 4 })

<% list.with_empty_state(
title: t(".blankslate_title"),
description: t(".blankslate_description"),
icon: :"op-backlogs",
spacious: true
) %>
list.with_empty_state(
title: t(".blankslate_title"),
description: t(".blankslate_description"),
icon: :"op-backlogs",
spacious: true
)

<% visible_work_packages.each.with_index do |work_package, index| %>
<% list.with_work_package_item(
work_package:,
project:,
params: all_backlogs_params,
component_klass: Backlogs::WorkPackageCardListItemComponent
) %>
visible_work_packages.each.with_index do |work_package, index|
list.with_work_package_item(
work_package:,
project:,
params: all_backlogs_params,
component_klass: Backlogs::WorkPackageCardListItemComponent
)

<% if truncated? && index == TRUNCATE_MIDDLE - 1 %>
<% list.with_item(
scheme: :neutral,
classes: "op-work-package-card-list--show-more-row",
data: { draggable_id: last_omitted_id }
) do %>
<%= render(
Primer::Beta::Button.new(
id: show_more_id,
scheme: :link,
tag: :a,
size: :large,
block: true,
align_content: :start,
underline: true,
href: project_backlogs_backlog_path(project, all: 1),
data: {
turbo_frame: "backlogs_container",
turbo_action: :advance
}
)
) { show_more_label } %>
<% end %>
<% end %>
<% end %>
<% end %>
if truncated? && index == TRUNCATE_MIDDLE - 1
list.with_item(
scheme: :neutral,
classes: "op-work-package-card-list--show-more-row",
data: { draggable_id: last_omitted_id }
) do
render(
Primer::Beta::Button.new(
id: show_more_id,
scheme: :link,
tag: :a,
size: :large,
block: true,
align_content: :start,
underline: true,
href: project_backlogs_backlog_path(project, all: 1),
data: {
turbo_frame: "backlogs_container",
turbo_action: :advance
}
)
) { show_more_label }
end
end
end
end
%>
<% end %>
Loading
Loading