Bump view_component to 4.0.2#350
Conversation
|
| render partial: "primer/view_components/auto_check/error_message", | ||
| locals: { input_value: params[:value] }, | ||
| status: :unprocessable_entity, | ||
| status: :unprocessable_content, |
There was a problem hiding this comment.
It's warning and suggested by Rails 8.0.2
Eric-Guo
force-pushed
the
bump_view_component
branch
from
57c65d0 to
6623e60
Compare
|
Hi @Eric-Guo Thanks for this PR. The primer people have updated to 4.0.2 by now as well, which is why we have some conflicts here. With regards to the change of the status code, do you mind providing that change upstream as well? I am pretty sure, that they will accept that as well and it would be could to have the repos in sync.. |
|
No problem, in fact @thape-cn is already running 4.0.2 at least 2 weeks. There is only three place need to change, maybe you would like change yourself? I'm also OK to propose a PR. |
Eric-Guo
force-pushed
the
bump_view_component
branch
from
6623e60 to
f0fa589
Compare
2 participants
What are you trying to accomplish?
Using new view_component version.
Integration
No need change code in production (open project)
List the issues that this change affects.
N/A
Risk Assessment
What approach did you choose and why?
I just run the test in my MacBook M4 Pro and don't want install too many view_component versions.
Anything you want to highlight for special attention from reviewers?
Nothing.
Accessibility
Not relative
Merge checklist