Skip to content

Bump/primer upstream#457

Open
myabc wants to merge 32 commits into
mainfrom
bump/primer-upstream
Open

Bump/primer upstream#457
myabc wants to merge 32 commits into
mainfrom
bump/primer-upstream

Conversation

@myabc
Copy link
Copy Markdown
Collaborator

@myabc myabc commented May 16, 2026

Note

Replaces #456

primer Bot and others added 28 commits April 18, 2026 01:12
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brittany L. Houtz <55068883+llastflowers@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#4042)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ies group (primer#4044)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 16, 2026

🦋 Changeset detected

Latest commit: 4e1b960

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@myabc myabc requested a review from Copilot May 16, 2026 19:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the OpenProject fork with the latest changes from upstream Primer ViewComponents. It bumps several dependencies (puma, view_component, yard, vite, @primer/primitives, rake), updates pinned GitHub Action SHAs, adjusts Dropdown CSS (caret positioning and shadow), and adds @snapshot interactive snapshot configuration to the dropdown direction previews.

Changes:

  • Dependency bumps in Gemfile/Gemfile.lock and demo (puma 7→8, view_component 4.6→4.9, yard 0.9.38→0.9.43, vite 8.0.9→8.0.10, @primer/primitives 11.6→11.7.1, rake 13.3→13.4).
  • Dropdown CSS adjustments: replace --shadow-floating-legacy fallback with --shadow-floating-small, refine caret positioning using calc() with --borderWidth-thin, and remove now-unneeded stylelint disable comments.
  • Add @snapshot interactive to dropdown direction previews; regenerate static/previews.json and static/info_arch.json accordingly.
  • Pin updated SHAs for tj-actions/changed-files and actions/cache in workflows.

Reviewed changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Gemfile, Gemfile.lock Bump puma, view_component, yard versions
demo/Gemfile, demo/Gemfile.lock Bump puma, view_component, rake versions in demo app
demo/package.json, demo/package-lock.json Bump @primer/primitives and vite (+ transitive deps)
app/components/primer/alpha/dropdown.pcss Update caret positioning, shadow token, and remove obsolete stylelint disables
previews/primer/alpha/dropdown_preview.rb Add @snapshot interactive to direction previews
static/previews.json, static/info_arch.json Regenerated snapshot values from preview changes
.changeset/fix-dropdown-caret-borders.md Add patch changeset for dropdown caret fix
.github/workflows/lint.yml, .github/workflows/demo-production-deploy.yml Bump pinned action SHAs
Files not reviewed (1)
  • demo/package-lock.json: Language not supported

@myabc myabc force-pushed the bump/primer-upstream branch from f035ac3 to 093d5ab Compare May 16, 2026 19:23
@myabc myabc requested review from a team and oliverguenther May 16, 2026 19:24
@myabc myabc force-pushed the bump/primer-upstream branch from 870dbb2 to 554990c Compare May 21, 2026 12:09
@myabc myabc requested a review from HDinger May 21, 2026 12:11
@github-actions
Copy link
Copy Markdown

⚠️ Visual or ARIA snapshot differences found

Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review differences

@myabc myabc marked this pull request as ready for review May 21, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants