Show leftover ordinals, keep landing buttons clear, and announce BAP names - #30
Merged
Merged
Conversation
…names Website inventory only listed the 1sat basket, so Yours theme tokens in leftover ordinals baskets never appeared. Dual-read those leftover names. The mobile landing tray sat on the hero CTAs. Pin it to the viewport bottom, lift the online chip, and keep the buttons above that chrome. Connected wallets already have identity. Announce the BAP display name and avatar on the trading floor as an unverified public profile.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Right-click (or long-press) on a peer used to fire a trade immediately. Use the shadcn context menu instead: request trade or copy the identity key. Left-click and the mobile tray still start a trade.
The context menu pulled in a second Radix stack (radix-ui + cn) next to the @radix-ui packages and @/lib/utils already used by dropdown-menu. Profile avatars reimplemented OrdFS URLs and HTTPS sanitizing. Leftover ordinal baskets restated names that @1sat/types already lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mobile landing puts the online-users tray on the Browser Wallet / Apple App buttons, so those CTAs cannot be tapped.
Assets from a connected 1Sat desktop wallet listed only the
1satbasket. Theme tokens inscribed in Yours still live in leftoverordinals/p 1sat ordinalsbaskets, so the site showed one inscription while desktop showed the rest.The P2P floor already accepts an unverified
publicProfileon presence, but connected BRC-100 wallets with a BAP identity still appeared as truncated keys.Change
listOrdinals, merging by outpoint. A denied leftover list is empty, not a hard failure.Atomic settlement is still gated on draft BRC-178. This only shows who is on the floor.
Risk
Listing leftover baskets may prompt a connected desktop wallet for those basket names once.
getProfilecan relinquish duplicate BAP aliases; presence caches the claim so that does not run every minute.