Play a coin chime and burst mark when a send lands - #33
Merged
Merged
Conversation
Replace the emerald Lucide check on a completed BSV send with the themed animated SVG, and play pay-chime after a txid. Clipboard still uses the existing success sound. Confirm unlocks audio before the wallet request so the chime can play after the await.
Astra's mockup pass: Payment Successful, amount, and gold Done stay in front. The txid sits under transaction details. Reduced motion no longer mutes the chime by itself.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A completed BSV send showed a Lucide check and the generic success click.
Change
gpt-6-astra designed the success dialog from the attached light/dark mockups, using existing 1Sat tokens. pay-chime.mp3 plays after a txid. Clipboard still uses the existing success sound.
Risk
Confirm unlocks Web Audio before the send so the chime can play after the await. Explicit mute still silences it.