Skip to content

Pin @1sat packages to the canonical OrdLock v2 release - #32

Draft
shruggr wants to merge 1 commit into
masterfrom
repin/ordlock-v2-canonical
Draft

shruggr wants to merge 1 commit into
masterfrom
repin/ordlock-v2-canonical

Conversation

@shruggr

@shruggr shruggr commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Repins the @1sat packages to the release carrying the canonical OrdLock v2 batch contract: actions ^0.0.208 → ^0.0.221, client 0.0.51 → 0.0.55, wallet-node 0.0.73 → 0.0.77 (pulls wallet 0.0.110, templates 0.0.37, types 0.0.48). The earlier v2 draft contract is deprecated, so the marketplace tools should not keep producing or buying listings against it.

The two bun patch files that add the autoStoragePayments opt-out are re-keyed to @1sat/wallet@0.0.110 and @1sat/wallet-node@0.0.77. The patched sites are unchanged upstream and the hunks apply cleanly to the installed dist (verified after a fresh bun install).

Validation: tsc --noEmit, bun run build, and bun test pass. The one failing test (Grok plugin packaging → published npm package) fails identically on master.

🤖 Generated with Claude Code

https://claude.ai/code/session_015UyixGQxRnUu3YA7EPDGZT

actions ^0.0.221, client 0.0.55, wallet-node 0.0.77 (pulls wallet 0.0.110,
templates 0.0.37, types 0.0.48). The marketplace listing/purchase tools now
use the canonical OrdLock v2 batch contract; the prior v2 draft contract is
deprecated.

The autoStoragePayments patches are re-keyed to @1sat/wallet@0.0.110 and
@1sat/wallet-node@0.0.77; the patched sites are unchanged upstream and the
hunks apply cleanly.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015UyixGQxRnUu3YA7EPDGZT
@vercel

vercel Bot commented Sep 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bsv-mcp Ready Ready Preview Sep 13, 2026 4:33am UTC

Request Review

@rohenaz rohenaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security review at e39c7391fa617334dec048d412dbc2c602923821 found one low-severity dependency compatibility issue to address before merge.

  1. package.json:63 still declares @bsv/sdk as ^2.4.2, while every upgraded package in the canonical OrdLock v2 graph (@1sat/actions, client, wallet, wallet-node, templates, and types) publishes a peer requirement of @bsv/sdk ^2.6.0. The submitted lock happens to resolve 2.6.0, but a narrow clean update from the base retained 2.4.2 and emitted six peer warnings. Please raise the direct floor to ^2.6.0 so a fresh or regenerated install cannot produce an unsupported combination on transaction-construction paths.

  2. The submitted lock refresh changes 54 resolved entries and migrates the lock format, including unrelated upgrades to Hono, Next, Vite, mysql2, zod, and tooling. A Bun 1.3.11 reproduction changed only the intended @1sat dependency graph (plus its nested message-box resolution), so this extra supply-chain surface is avoidable. Please regenerate narrowly or split those upgrades into a separately reviewed PR.

The intended dependency set otherwise checked out: published package integrity matches the lock, both re-keyed patches are byte-identical and apply cleanly, frozen install/typecheck/build pass, and 38 focused OrdLock/package tests pass. The full suite was 757 pass / 1 known base-equivalent Grok plugin-version failure. No key was loaded and no transaction was signed or broadcast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants