unbound: add per-policy quick actions in reporting overview. #9559
+335
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Dec 23, 2025
src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/OverviewController.php
Outdated
Show resolved
Hide resolved
swhite2
commented
Dec 23, 2025
| title: "{{ lang._('Quick action') }}", | ||
| classname: 'fa fa-cogs', | ||
| sequence: 100, | ||
| filter: function(cell) { |
Member
Author
There was a problem hiding this comment.
note to reviewer: this code utilizes d25a8ac, which is currently only on master.
AdSchellevis
requested changes
Dec 23, 2025
Member
AdSchellevis
left a comment
AdSchellevis
left a comment
There was a problem hiding this comment.
@swhite2 a couple of small remarks, but looks good. thanks!
| parser_obj = BlocklistParser() | ||
|
|
||
| if args.command == "modify": | ||
| parser_obj.modify_blocklist(args.uuid, args.domain, args.action) |
Member
There was a problem hiding this comment.
the "quick" update option is quite nice, but likely needs locking to prevent two instances updating the list at the same time.
Member
Author
There was a problem hiding this comment.
this is already handled through the BlocklistParser constructor. However, error handling in this case may be improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more visibility into the blocklist hit, more control over which blocklist should act on a given domain and improves the dnsbl update time for such quick updates by introducing the
dnsblquickconfigd action.