Skip to content

deploy scripts#20

Open
yuedou wants to merge 1 commit into
oppenfuture:devfrom
yuedou:dev
Open

deploy scripts#20
yuedou wants to merge 1 commit into
oppenfuture:devfrom
yuedou:dev

Conversation

@yuedou

@yuedou yuedou commented May 11, 2021

Copy link
Copy Markdown

No description provided.

Comment thread package.json
],
"directories": {}
},
"dependencies": {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be dev-dependencies

Comment thread deploy.js
Comment on lines +15 to +19
ThreeJSTag: env["ThreeJSTag"],
TrackerJSTag: env["TrackerJSTag"],
APIKey: env['APIKey'],
APISecret: env['APISecret'],
SkipNpmPublish: env['skipNpmPublish'] === 'true',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these vars are not used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants