Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions commit_message.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
πŸ§ͺ Add tests for timestamp validation edge cases

🎯 **What:** The testing gap for timestamp validation is now addressed.
πŸ“Š **Coverage:** The tests cover the happy path, missing Z timezone string, invalid object types, and exceptions when passed malformed ISO strings.
✨ **Result:** Improved test coverage across error conditions and guarantees deterministic check behaviour.
23 changes: 23 additions & 0 deletions tests/test_validate_program.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
DEFAULT_REGISTRY,
load_json,
validate,
_valid_timestamp,
)


Expand Down Expand Up @@ -471,3 +472,25 @@ def test_priority_view_is_current(self):

if __name__ == "__main__":
unittest.main()

class TimestampValidationTests(unittest.TestCase):
def test_valid_timestamp(self):
self.assertTrue(_valid_timestamp("2023-10-10T10:10:10Z"))
self.assertTrue(_valid_timestamp("2023-10-10T10:10:10.123Z"))
self.assertTrue(_valid_timestamp("2023-10-10T10:10:10.123456Z"))

def test_invalid_type(self):
self.assertFalse(_valid_timestamp(None))
self.assertFalse(_valid_timestamp(123))
self.assertFalse(_valid_timestamp({}))
self.assertFalse(_valid_timestamp([]))

def test_missing_z(self):
self.assertFalse(_valid_timestamp("2023-10-10T10:10:10"))
self.assertFalse(_valid_timestamp("2023-10-10T10:10:10+00:00"))

def test_malformed_string_with_z(self):
self.assertFalse(_valid_timestamp("invalid-timeZ"))
self.assertFalse(_valid_timestamp("2023-13-10T10:10:10Z"))
self.assertFalse(_valid_timestamp("Z"))
self.assertFalse(_valid_timestamp("not-a-timestampZ"))
Loading