-
Notifications
You must be signed in to change notification settings - Fork 1
Replace with onechart #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -14,30 +14,30 @@ OneChart is a generic Helm Chart for web applications. The idea is that most Kub | |||||
|
|
||||||
| You can also template and install onechart from an OCI repository as follows: | ||||||
|
|
||||||
| > **Note:** The examples use version `0.80.0`. This will be the unreleased version if you are at the `main` branch. | ||||||
| > **Note:** The examples use version `0.79.0`. This will be the unreleased version if you are at the `main` branch. | ||||||
|
|
||||||
| > You can find the latest released version in the [releases](https://github.com/opsta/onechart/releases) page. | ||||||
|
|
||||||
| Check the generated Kubernetes yaml: | ||||||
|
|
||||||
| ```bash | ||||||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.80.0 \ | ||||||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The OCI repository URL should be updated to reflect the new chart name
Suggested change
|
||||||
| --set image.repository=nginx \ | ||||||
| --set image.tag=1.19.3 | ||||||
| ``` | ||||||
|
|
||||||
| Deploy with Helm: | ||||||
|
|
||||||
| ```bash | ||||||
| helm install my-release oci://ghcr.io/opsta/onechart --version 0.80.0 \ | ||||||
| helm install my-release oci://ghcr.io/opsta/onechart --version 0.79.0 \ | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
| --set image.repository=nginx \ | ||||||
| --set image.tag=1.19.3 | ||||||
| ``` | ||||||
|
|
||||||
| The example below deploys your application image, sets environment variables and configures the Kubernetes Ingress domain name: | ||||||
|
|
||||||
| ```bash | ||||||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.80.0 -f values.yaml | ||||||
| helm template my-release oci://ghcr.io/opsta/onechart --version 0.79.0 -f values.yaml | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
|
|
||||||
| # values.yaml | ||||||
| image: | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| apiVersion: v2 | ||
| name: onechart | ||
| name: onechart-cnpg | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The chart name has been changed from |
||
| description: One chart to rule them all. A generic Helm chart for your application deployments. Because no-one can remember the Kubernetes yaml syntax. | ||
|
|
||
| # A chart can be either an 'application' or a 'library' chart. | ||
|
|
@@ -15,13 +15,13 @@ type: application | |
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.80.0 | ||
| version: 0.79.0 | ||
|
|
||
| dependencies: | ||
| - name: common | ||
| version: 0.9.0 | ||
| repository: file://../common | ||
|
|
||
| - name: cnpg | ||
| version: 0.1.0 | ||
| repository: file://../cnpg | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the chart has been renamed to
onechart-cnpg, this note should be updated to avoid confusion.