WIP: - Parse Host, Port, Image and Tag with regular expressions #64
Open
bougar wants to merge 5 commits into
Open
WIP: - Parse Host, Port, Image and Tag with regular expressions #64bougar wants to merge 5 commits into
bougar wants to merge 5 commits into
Conversation
- Dockerfile uses alpine
- Fixed code to work with no_registry_root registries
Contributor
|
the first version used regexs, we switched to custom parsing later on 876ecd8 |
Contributor
Author
|
What's the point in using custom implementation instead regex? :D |
Contributor
|
One pass instead of multiple matches as it was before, you approach looks interesting |
supereagle
reviewed
Nov 4, 2017
| state = stateTag | ||
| } | ||
| nameParts = append(nameParts, part) | ||
| if !utils.ImageOnlyRegexp.MatchString(string(qname)) || strings.HasPrefix(qname, "localhost/") { |
Contributor
There was a problem hiding this comment.
The type of qname already is string, why still need to convert it?
Contributor
Author
There was a problem hiding this comment.
Ups, I thought it was a byte. There is no point in convert string into string XD
supereagle
reviewed
Nov 4, 2017
supereagle
left a comment
supereagle
left a comment
Contributor
There was a problem hiding this comment.
The approach is good, which makes it much clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.