feat(collector): implement crash-loop safety and panic recovery#159
Open
wazer24 wants to merge 3 commits into
Open
feat(collector): implement crash-loop safety and panic recovery#159wazer24 wants to merge 3 commits into
wazer24 wants to merge 3 commits into
Conversation
Signed-off-by: wazer24 <24wazer@rbunagpur.in>
Signed-off-by: wazer24 <24wazer@rbunagpur.in>
|
🚀 First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
Signed-off-by: wazer24 <24wazer@rbunagpur.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implemented crash-loop safety and panic recovery mechanisms for the collector goroutines, while resolving architectural feedback on graceful daemon shutdown and Prometheus cardinality. Also, restored missing BPF collector map wirings and updated modern Go syntax across the package.
Why
Fixes #95
How
RunSafeCollectorGoroutineincollector.goto recover from panics, log them, and permanently disable the offending collector instead of endlessly looping to prevent deadlocks.os.Exit(2)calls from library code (internal/cli/start.go). Daemon panic errors are now bubbled up gracefully and handled inmain.go.KERNO_PANIC_LOG_DIR. Leaving this environment variable unset disables file-based panic logging, defaulting safely to stdout/stderr.reasonlabel fromCollectorPanicsTotalto prevent excessive Prometheus memory consumption.CgroupMemorywiring inRegistry.Signalsthat was accidentally dropped in an older base branch.internal/collector/*.goSnapshot methods frominterface{}toany.Testing
go build ./...passesgo test ./...passesgo vet ./...passesgolangci-lint run ./...passesgo test -v ./internal/collector -run TestCollectorPanicRecoverysudo ./bin/bpf-verify --read 5sconfirms 6/6 programs still load./scripts/verify.shpasses (or specific phase:./scripts/verify.sh quality)Checklist
feat(scope): subject)git commit -s)scripts/verify.sh