fix(ai): default analyzer logger to discard when cfg.Logger is nil#177
Closed
HarshParmar029 wants to merge 2 commits into
Closed
fix(ai): default analyzer logger to discard when cfg.Logger is nil#177HarshParmar029 wants to merge 2 commits into
HarshParmar029 wants to merge 2 commits into
Conversation
|
🚀 First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
…ard logger when cfg.Logger is nil Signed-off-by: Harsh <hp259369@gmail.com>
1caaf71 to
800ae4a
Compare
Signed-off-by: Harsh <hp259369@gmail.com>
Author
|
Hi @btwshivam All CI checks are now passing — including Lint, Build, Test, and Docker. This PR fixes the nil-pointer panic in Would appreciate a review when you get a chance. Happy to make any changes if needed! |
Author
|
Hi @btwshivam, Just a gentle follow-up — all CI checks are green, and this fixes the nil logger panic in NewAnalyzer (ref #126). Happy to address any feedback or make changes. Thanks for your time! |
Member
|
/close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126
Problem
NewAnalyzerdid not handlecfg.Logger == nil, causing a nil-pointerpanic on any logging call (e.g.
a.logger.Debug(...)).Fix
Added a nil check in
NewAnalyzer. Whencfg.Loggeris nil, it defaultsto
slog.New(slog.NewTextHandler(io.Discard, nil))— a no-op logger thatproduces no output but never panics.
Testing