feat(cli): add --private flag for login-gated share links#33
Open
abhinav-1504 wants to merge 2 commits into
Open
feat(cli): add --private flag for login-gated share links#33abhinav-1504 wants to merge 2 commits into
abhinav-1504 wants to merge 2 commits into
Conversation
|
First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
0071703 to
8f48b45
Compare
Author
|
Hello @btwshivam, Ready for review. All CI checks pass and DCO is signed.
|
Author
|
Hi @btwshivam , just following up on this PR. All CI checks are passing and the implementation has been tested locally as mentioned above. Could you please take another look when possible? Thanks. |
Signed-off-by: Abhinav Singh Chauhan <abhinavsinghc48@gmail.com>
8f48b45 to
d3083c5
Compare
Author
|
Hi @btwshivam, resolved the merge conflicts and force-pushed. Branch is clean and all checks are passing. Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
--privateflag to theanalyzecommand. When passed alongside--share, the upload request includesX-Optiqor-Private: 1so thesandbox receiver can return a login-gated URL (backend Phase 2 work).
Why
Fixes #23
How
--privatebool flag onanalyzenext to--share--privatewithout--sharereturns an errorshare.Upload()accepts a newprivate boolparam and conditionallysets
X-Optiqor-Private: 1on the POST request(uploaded · login-gated)when private=trueTesting
go test ./internal/share/... -v— 11/11 PASSgo build ./...— clean./cmd/optiqor/demo/values.yaml:--sharealone → URL printed--privatealone → error returned--share --private→ URL printed with login-gated suffix--help→--privateflag listed correctlyChecklist
feat(scope): subject)