Skip to content

Feat/openapi spec#38

Merged
btwshivam merged 7 commits into
mainfrom
feat/openapi-spec
May 24, 2026
Merged

Feat/openapi spec#38
btwshivam merged 7 commits into
mainfrom
feat/openapi-spec

Conversation

@btwshivam
Copy link
Copy Markdown
Member

What

Why

Fixes #

How

Testing

  • make lint test passes locally
  • go test -race ./... passes
  • If a new rule: added a chart fixture in testdata/ and a golden output
  • Tested locally with:

Checklist

  • PR title follows Conventional Commits (feat(scope): subject)
  • All commits are DCO-signed (git commit -s)
  • No unrelated changes pulled in
  • Documentation updated where user-visible behavior changed
  • No LLM calls or telemetry introduced
  • No proprietary backend imports

btwshivam added 5 commits May 24, 2026 04:33
Signed-off-by: btwshivam <shivam200446@gmail.com>
Signed-off-by: btwshivam <shivam200446@gmail.com>
…ep WHY-context

Signed-off-by: btwshivam <shivam200446@gmail.com>
…+ restore minimal godoc on exported symbols for revive

Signed-off-by: btwshivam <shivam200446@gmail.com>
…/htmlrender

Signed-off-by: btwshivam <shivam200446@gmail.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation testing Test coverage and golden fixtures area/rules Cost / security rules engine area/parser YAML / Helm parser area/cli Cobra CLI commands and UX area/analyze Helm chart analyzer area/render Terminal renderer (TUI, HTML, JSON) area/share Share-link feature (internal/share) area/config Configuration (internal/config) area/roast Roast mode (internal/roast) size/XL 501+ lines (consider splitting) labels May 24, 2026
btwshivam added 2 commits May 24, 2026 09:35
Resolved conflicts by taking our branch's TDT-consolidated tests and
godoc-restored source files (needed for revive); merged the two
CLAUDE.md edits to keep the no-`_TableDriven`-suffix rule + main's
'every detector needs positive+negative' and 90% pkg/ coverage bullets.

Bumped TestAll_DetectorCountAndUniqueIDs from 30 to 31 to absorb
the new idle-workload detector (#32).

Signed-off-by: btwshivam <shivam200446@gmail.com>
Three CLAUDE.md links pointed at .claude/skills/{commit,pr-review,open-issue}/SKILL.md,
which are local-only tooling and not tracked. Inlined the rule summaries
instead.

SKILL.md referenced pkg/rules/cpu_overprovisioned_test.go which never
existed; the CPU detector tests live in rules_test.go.

Signed-off-by: btwshivam <shivam200446@gmail.com>
@btwshivam btwshivam merged commit aa0a4f0 into main May 24, 2026
10 of 11 checks passed
@btwshivam btwshivam deleted the feat/openapi-spec branch May 24, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/analyze Helm chart analyzer area/cli Cobra CLI commands and UX area/config Configuration (internal/config) area/parser YAML / Helm parser area/render Terminal renderer (TUI, HTML, JSON) area/roast Roast mode (internal/roast) area/rules Cost / security rules engine area/share Share-link feature (internal/share) documentation Improvements or additions to documentation size/XL 501+ lines (consider splitting) testing Test coverage and golden fixtures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant