feat(rules): populate Signal bars on 8 remaining cost detectors#44
Open
abhinav-1504 wants to merge 5 commits into
Open
feat(rules): populate Signal bars on 8 remaining cost detectors#44abhinav-1504 wants to merge 5 commits into
abhinav-1504 wants to merge 5 commits into
Conversation
Signed-off-by: Abhinav Singh Chauhan <abhinavsinghc48@gmail.com>
|
First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
Signed-off-by: Abhinav Singh Chauhan <abhinavsinghc48@gmail.com>
Signed-off-by: Abhinav Singh Chauhan <abhinavsinghc48@gmail.com>
Author
|
Hello @btwshivam, Waiting for your review!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Populates the
Signalfield on 8 cost detectors that previouslyreturned an empty
Signal{}, enabling the inline ratio bars in theASCII report.
Why
Fixes #13
How
oversized_limits.go— CPU/memory request vs limit ratio with"limit > 4 vCPU / limit > 16 GiB" note
excessive_replicas.go— threshold (20) vs actual replica counttiny_request.go— actual request vs 10m/32Mi sentinel valuesincomplete_request.go—HaveDisplay: "unset",WantDisplay: "required"for the missing-dimension case; numericbar is skipped when Have/Want are both 0, showing only the label text
Testing
go test ./pkg/rules/... -v— all PASSgo build ./...— cleanoptiqor demoshows ratio bars for:megabox→ CPU limit > 4 vCPU bar, memory limit > 16 GiB bar,replica count bar
incomplete→ CPU sentinel bar, memory unset labelmemhog→ CPU unset label, memory sentinel barChecklist