Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions optunahub/hub.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,12 @@ def load_local_module(
module = importlib.util.module_from_spec(spec)
if module is None:
raise ImportError(f"Module {module_name} not found in {module_path}")
previous_module = sys.modules.get(module_name)
if previous_module is not None and previous_module.__file__ != module.__file__:
# Relative imports must come from the newly selected registry root.
for name in list(sys.modules):
if name.startswith(module_name + "."):
del sys.modules[name]
sys.modules[module_name] = module
spec.loader.exec_module(module)

Expand Down
36 changes: 36 additions & 0 deletions tests/test_local_registry_roots.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
from __future__ import annotations

from pathlib import Path
import sys

import pytest

import optunahub


@pytest.mark.parametrize("package", ["root_switch", "samplers/root_switch"])
@pytest.mark.parametrize("different_root", [False, True])
def test_load_local_module_registry_root(
tmp_path: Path, package: str, different_root: bool
) -> None:
roots = [tmp_path / "first", tmp_path / "second"]
for value, root in enumerate(roots, start=1):
package_dir = root / package
package_dir.mkdir(parents=True)
(package_dir / "__init__.py").write_text("from .values import VALUE\n", encoding="utf-8")
(package_dir / "values.py").write_text(f"VALUE = {value}\n", encoding="utf-8")

module_name = f"optunahub_registry.package.{package.replace('/', '.')}"
try:
first = optunahub.load_local_module(package, registry_root=str(roots[0]))
assert first.VALUE == 1
root = roots[1] if different_root else roots[0]
second = optunahub.load_local_module(package, registry_root=str(root))
assert second.__file__ is not None
assert Path(second.__file__) == root / package / "__init__.py"
assert second.VALUE == (2 if different_root else 1)
assert first.VALUE == 1
finally:
for name in list(sys.modules):
if name == module_name or name.startswith(module_name + "."):
del sys.modules[name]
Loading