Skip to content

Parameterize and harden dehydrated::renew Bolt task #86

Merged
smortex merged 2 commits intomainfrom
more-fixes
Apr 23, 2026
Merged

Parameterize and harden dehydrated::renew Bolt task #86
smortex merged 2 commits intomainfrom
more-fixes

Conversation

@neomilium
Copy link
Copy Markdown
Member

@neomilium neomilium commented Apr 23, 2026

Accept an optional dehydrated_bin task parameter, fall back to a PATH lookup before the existing hardcoded probes, and always pass --accept-terms so the task works on freshly provisioned hosts. Switch
-c to --cron to use the same long-option style as the cron and systemd entry points.

Declaring dehydrated_bin in renew.json is required for Bolt to pass the value through as PT_dehydrated_bin.

Also include: #87

Collapse each function to its return expression, declare the explicit
>> String return type, and drop the temporary variables (one of which
was named after a different function). Also fix the "cerificate" typo
in the @return docstrings.

No behaviour change: the assignment form was already returning the
correct value by accident, because Puppet takes the last expression
as the function result.

Made-with: Cursor
Accept an optional dehydrated_bin task parameter, fall back to a PATH
lookup before the existing hardcoded probes, and always pass
--accept-terms so the task works on freshly provisioned hosts. Switch
-c to --cron to use the same long-option style as the cron and
systemd entry points.

Declaring dehydrated_bin in renew.json is required for Bolt to pass
the value through as PT_dehydrated_bin.

Made-with: Cursor
@neomilium neomilium requested review from a team as code owners April 23, 2026 20:58
@smortex smortex added skip-changelog Excluded from CHANGELOG labels Apr 23, 2026
@neomilium neomilium changed the title More fixes Parameterize and harden dehydrated::renew Bolt task Apr 23, 2026
@smortex smortex added enhancement New feature or request and removed skip-changelog Excluded from CHANGELOG labels Apr 23, 2026
@smortex smortex merged commit 83415d3 into main Apr 23, 2026
9 checks passed
@smortex smortex deleted the more-fixes branch April 23, 2026 21:05
@smortex smortex changed the title Parameterize and harden dehydrated::renew Bolt task Parameterize and harden dehydrated::renew Bolt task Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants