docs(a2a): update notebook 28 to A2A v1.0 surface#275
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
Notebook 28 was still walking through the legacy method names (message/send, tasks/get, tasks/cancel, message/stream) and didn't demonstrate the v1.0 path that A2AClient now defaults to. Refresh the example + mkdocs wrapper: - Agent Card output now prints protocolVersion and supportedInterfaces. - Rename Parts 3/4/6/7 to SendMessage / GetTask / CancelTask / SendStreamingMessage and call out the A2A-Version: 1.0 default. - Add a ListTasks (v1.0) section showing context_id + status paging. - Add a legacy fallback section that constructs an A2AClient with protocol_version=None to exercise the pre-v1.0 method names. - Mirror the same framing in docs/notebooks/notebook_28_a2a_protocol.md. Verified by running the example end-to-end against live OCI GenAI (meta.llama-3.3-70b-instruct and openai.gpt-5.5 on LUIGI_FRA_API / us-chicago-1) - all 10 parts complete with no mocking, including TaskNotCancelable (-32002) and the legacy fallback path. Signed-off-by: Federico Kamelhar <federico.kamelhar@oracle.com>
fede-kamel
force-pushed
the
feat/a2a-v1-protocol-compat
branch
from
098dc6d to
abb0916
Compare
fede-kamel
changed the title
Contributor
|
Good catch, @fede-kamel. I missed this NB. I’ll take a closer look at this PR and should be able to complete the review by close of business today, CET. |
luigisaetta
requested changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Good, all the code is working fine.
Only some small things good to fix, all regarding the numbering of the notebooks:
- (line 5) NOB 29 should be NB 28
- (line 31) notebook_34_a2a_protocol.py should be notebook_28
- (line 94) print("Notebook 29 ...) should be 28
Luigi noticed the example header still said "Notebook 29" in two places and the docstring run-it line referenced notebook_34. The file is notebook_28, so align all three references. - Line 5: docstring title 29 -> 28 - Line 31: run-it path notebook_34 -> notebook_28 - Line 94: print header 29 -> 28 Signed-off-by: Federico Kamelhar <federico.kamelhar@oracle.com>
Contributor
Author
|
Thanks @luigisaetta — all three fixed in 4f427b3:
|
luigisaetta
approved these changes
May 27, 2026
Contributor
luigisaetta
left a comment
luigisaetta
left a comment
There was a problem hiding this comment.
Approved after the notebook numbering fixes in 4f427b3. CI is green and the A2A notebook changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notebook 28 was still walking through the legacy A2A method names (
message/send,tasks/get,tasks/cancel,message/stream) and didn't demonstrate the v1.0 path thatA2AClientnow defaults to after #272. Refresh the example + mkdocs wrapper:protocolVersionandsupportedInterfaces.SendMessage/GetTask/CancelTask/SendStreamingMessage, with a call-out thatA2A-Version: 1.0is the default.ListTasks(v1.0) showingcontext_id+statuspaging.A2AClient(..., protocol_version=None)to exercise the pre-v1.0 method names.docs/notebooks/notebook_28_a2a_protocol.mdupdated to mirror the same framing.Follow-up
a2a-meshdemo (examples/projects/a2a-mesh/) still uses the legacy/a2a/invokeand/a2a/streamendpoints. Out of scope for this PR; tracked separately.Test plan
LOCUS_MODEL_PROVIDER=mock python examples/notebook_28_a2a_protocol.py— offline path, all 10 parts pass.LOCUS_MODEL_PROVIDER=oci LOCUS_OCI_PROFILE=LUIGI_FRA_API LOCUS_OCI_REGION=us-chicago-1 LOCUS_MODEL_ID=meta.llama-3.3-70b-instruct python examples/notebook_28_a2a_protocol.py— live OCI GenAI, all 10 parts pass.LOCUS_MODEL_ID=openai.gpt-5.5— all 10 parts pass.TaskNotCancelable(-32002) surfaces on the terminal-task cancel attempt; legacyprotocol_version=Nonefallback also returnscompleted.