Skip to content

test(workbench/e2e): poll for Model B/C options before selectOption #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fede-kamel merged 1 commit into from
May 6, 2026
Merged

test(workbench/e2e): poll for Model B/C options before selectOption #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions workbench/e2e/tests/all-anthropic.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,21 @@ async function configureAnthropic(page: Page): Promise<void> {
expect(opts.includes(MODEL)).toBe(true);
}).toPass({ timeout: 15_000 });
await page.getByTestId("cfg-model").selectOption(MODEL);
if (MODEL_B) await page.getByTestId("cfg-model-b").selectOption(MODEL_B);
if (MODEL_C) await page.getByTestId("cfg-model-c").selectOption(MODEL_C);
// The B/C dropdowns are populated by the same setModelOptions pass
// as A but the option list may not have flushed to the WebDriver
// layer by the time selectOption fires — poll for the target option
// to exist before attempting to set it.
for (const [tid, value] of [
["cfg-model-b", MODEL_B] as const,
["cfg-model-c", MODEL_C] as const,
]) {
if (!value) continue;
await expect(async () => {
const opts = await page.getByTestId(tid).locator("option").allTextContents();
expect(opts.includes(value)).toBe(true);
}).toPass({ timeout: 15_000 });
await page.getByTestId(tid).selectOption(value);
}
await page.getByTestId("settings-save").click();
}

Expand Down
Loading