Skip to content

CI failure tickets: only for main, and always deliverable - #1990

Merged
orbi-build[bot] merged 2 commits into
mainfrom
orbi/orbi-build-orbi-issue-1988
Oct 29, 2026
Merged

CI failure tickets: only for main, and always deliverable#1990
orbi-build[bot] merged 2 commits into
mainfrom
orbi/orbi-build-orbi-issue-1988

Conversation

@orbi-build

@orbi-build orbi-build Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #1988

CI failure tickets: only for main, and always deliverable (run_id=6b9362ce)

Built by Orbi from Issue #1988

@orbi-build
fix: triage only main CI failures and always state the outcome
c46a5e1 
A failing CI run on a pull_request no longer files or updates a ticket
(#1988): the PR's own review/fix loop owns its CI, and a ticket filed for a
PR branch outlives the PR (#1951 for #1944). Only a push to main (and the
unchanged Groq catalog schedule/dispatch path) may create or update a triage
Issue.

The generated body now carries the two fixed lines the clarification gate
reads — `Outcome: the failing job (<job name>) passes on main again.` and
`Acceptance: the same job is green on main after the fix; the fix touches
the failing test or the code it tests.` — so a main failure ticket is
deliverable instead of stopping at ai-needs-detail.

The now-unreachable pull_request route is removed rather than left dead:
PR resolution in the failure path, the source-delivery routing (label flip
plus evidence comments), the external-PR marker and the PR-shaped title and
branch display. The recovery guard keeps resolve_pr_number /
fetch_pull_request / closing_issue_numbers (a push recovery run still reads
commits/{sha}/pulls), and the workflow's pull-requests permission drops from
write to read.

Tests: 5421 -> 5395 collected (28 pull_request-route tests removed, 2 tests
for this Issue added). tools/ci_failure_triage.py stays at 100% line/branch.
@orbi-build orbi-build Bot mentioned this pull request Oct 29, 2026
Closed
@orbi-build

orbi-build Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Review evidence for #1988 acceptance item 3 (test counts before and after), recorded by the independent review of head e06fcc87 (c46a5e19 plus two now-unused delivery-label imports removed from the triage test file):

Raised contradiction (human decision, not silently resolved): AGENTS.md:384 still states that the CI-failure triage files an external contributor's pull_request CI failure as a ticket carrying <!-- orbi:external-pr:<n> -->. After this change the triage handles only a push to main (plus the unchanged Groq schedule/dispatch path), so that producer no longer exists; its consumers (the fifth claim scan, the external takeover, .github/workflows/pr-issue-link.yml) are unchanged, and src/orbi/gitops.py:82 / src/orbi/notify.py:585 still name the triage as a co-caller of is_delivery_branch. Whether to restore the external-PR producer (for example in pr-issue-link.yml) or to update AGENTS.md is the maintainer's call.

@orbi-build
orbi-build Bot merged commit 47eed4b into main Oct 29, 2026
1 check passed
@orbi-build
orbi-build Bot deleted the orbi/orbi-build-orbi-issue-1988 branch October 29, 2026 09:06
@orbi-build

orbi-build Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

✅ Orbi 已交付 · 查看交付证明 →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI failure tickets: only for main, and always deliverable

0 participants