Skip to content

Set owner on strategies #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobbieTheWagner merged 1 commit into from
Oct 9, 2025
Merged

Set owner on strategies #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/-private/system/ember-orbit-setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ interface FactoryForFolderType {
'/data-buckets/': { default: { create(injections: object): Bucket } };
'/data-models/': { default: ModelFactory };
'/data-sources/': { default: typeof MemorySourceFactory };
'/data-strategies/': { default: { create(): Strategy } };
'/data-strategies/': { default: { create(injections: object): Strategy } };
}

function registerDataBuckets(owner: Owner, modules: Record<string, unknown>) {
Expand Down Expand Up @@ -79,17 +79,24 @@ function registerDataSources(owner: Owner, modules: Record<string, unknown>) {
}
}

function registerDataStrategies(modules: Record<string, unknown>) {
function registerDataStrategies(
owner: Owner,
modules: Record<string, unknown>,
) {
const folder = '/data-strategies/';
const registry = orbitRegistry.registrations.strategies;

for (const [key, module] of Object.entries(modules)) {
let [, name] = key.split(folder);
name = getName(name as string);

const strategySettings = {};

setOwner(strategySettings, owner);

registry[name] = (
module as FactoryForFolderType['/data-strategies/']
).default?.create?.();
).default?.create?.(strategySettings);
}
}

Expand Down Expand Up @@ -146,11 +153,13 @@ function registerModules(owner: Owner, modules: Record<string, unknown>) {
registerInjectableServices(owner);
// Then register the sources themselves
registerDataSources(owner, sourceModules);
registerDataStrategies(strategyModules);
registerDataStrategies(owner, strategyModules);

const storeSourceSettings = {} as MemorySourceSettings;
setOwner(storeSourceSettings, owner);
// Register the store source after registering all modules
orbitRegistry.registrations.sources['store'] = DataSourceStore.create(
{} as MemorySourceSettings,
);
orbitRegistry.registrations.sources['store'] =
DataSourceStore.create(storeSourceSettings);
const storeSettings = {} as StoreSettings;
setOwner(storeSettings, owner);
orbitRegistry.services.store = StoreService.create(storeSettings);
Expand Down