Conversation
Contributor
Author
|
FYI @christywastaken. These changes will mean that only one env var is require for the processor:
And it will take the form of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some background, there are two addresses (or IPs) at play:
When orca core and the processor are on the same local network these two addresses are the same. But, when using the orca cli (for example), these are different as orca core is sitting inside a docker network. It has to reach the host network via a static IP.
In any case, the port in both these scenarios is the same, and the processor is always exposed on
[::]- i.e. all network interfaces. So we can collapse the two env vars into 1 and just split out the port and address.