Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request focuses on standardizing and simplifying parameter naming throughout the codebase, primarily replacing verbose or prefixed parameter names with shorter, clearer ones. It also updates related documentation, test code, and interface definitions to maintain consistency and improve readability.
The most important changes are:
Parameter Naming Standardization and Interface Simplification:
pTableName,pColumnsValues,pSQLCommand) with shorter, more descriptive names (e.g.,table,columns,values,sql,args) throughout theDDLSQLBuilderandDMLSQLBuilderinterfaces and their implementations inbuilder.goanddialects/postgresql/builder.go. This change also updates function signatures and documentation examples accordingly. [1] [2]DatabaseDriverinterface to use concise parameter names (params,db) instead of prefixed ones, and refactored theOpenDatabasefunction and its usage to match the new naming convention indatabase.go. [1] [2]Test Code Refactoring:
builder_test.goanddatabase_test.goto use the new parameter names and local variable conventions, ensuring consistency with the production code changes. [1] [2]Migration Example Consistency:
README.mdto usetableinstead oftableNamefor variable names, aligning with the new naming conventions. [1] [2]To ensure no more prefixes are present, perform a search with the following regular expression:
Resolves #8