Conversation
maze88
suggested changes
Jan 16, 2026
Member
maze88
left a comment
maze88
left a comment
There was a problem hiding this comment.
I have performed a basic review, here is a summary of my coverage and findings:
- I sampled several source (markdown) files and found their content to be well translated. I did not read all pages.
- I then explored this staged deployment in which I browsed around and sampled a dozen or so pages, skimming through them visually - mostly searching for common RTL (right-to-left) language glitches; I didn't encounter any.
- The majority of what I saw LGTM...
- ...However I did catch several issues whose patterns should be checked for (perhaps by some script/linter?) accross all pages:
- Images should be wrapped with empty lines: https://ef287772.organicmaps.pages.dev/he/faq/linux/how-to-use-flatpak/
- Last screenshot is far to wide (issue exists also in original [english] page): https://ef287772.organicmaps.pages.dev/faq/voice/text-to-speech-tts-and-voice-directions-on-android/
- Raw (unrendered) markdown appears in some of the news pages. Here are three examples (but I reckon there are many more):
Signed-off-by: Alexander Borsuk <me@alex.bio>
Deploying organicmaps with
|
| Latest commit: |
0c57f32
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8d51b479.organicmaps.pages.dev |
| Branch Preview URL: | https://ab-he.organicmaps.pages.dev |
Member
Author
|
@maze88 thanks a lot for the review and issues! Fixed everything except that large image… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @organicmaps/translators-he