Skip to content

[limen GEN-organvm-portfolio-test-coverage-0624] Raise test coverage in organvm/portfolio#154

Merged
4444J99 merged 1 commit into
mainfrom
limen/gen-organvm-portfolio-test-coverage-0624-dfe1
Jun 27, 2026
Merged

[limen GEN-organvm-portfolio-test-coverage-0624] Raise test coverage in organvm/portfolio#154
4444J99 merged 1 commit into
mainfrom
limen/gen-organvm-portfolio-test-coverage-0624-dfe1

Conversation

@4444J99

@4444J99 4444J99 commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Autonomous limen dispatch of task GEN-organvm-portfolio-test-coverage-0624.

Find the largest source module in organvm/portfolio with little or no test coverage and add a focused, PASSING test suite for it. Run the repo's own test command and confirm green. No placeholder tests. [auto-generated 2026-06-24 to keep the stream endless]

Produced in an isolated worktree off origin — review before merge.

limen task GEN-organvm-portfolio-test-coverage-0624
@4444J99 4444J99 enabled auto-merge (squash) June 27, 2026 01:52
@4444J99 4444J99 merged commit fb75a8b into main Jun 27, 2026
1 check passed
@4444J99 4444J99 deleted the limen/gen-organvm-portfolio-test-coverage-0624-dfe1 branch June 27, 2026 01:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0dbcee161e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +144 to +148
afterEach(() => {
vi.unstubAllGlobals();
vi.resetModules();
vi.clearAllMocks();
document.body.innerHTML = '';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clean up sketch-loader state between tests

These tests import sketch-loader and call initSketches/reinitPage, which registers a window resize listener and stores p5 instances in module state, but the shared afterEach only resets the module cache and globals. Because vi.resetModules() does not remove event listeners that were already attached to window, later resize tests run handlers left by earlier tests against stale observedContainers, making the suite order-dependent and prone to timer leaks; call the imported teardown()/teardownPage() before resetting modules.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant