Tighten types in organvm/portfolio#155
Open
4444J99 wants to merge 1 commit into
Open
Conversation
- chart-loader.ts: add explicit `: unknown` return types on parseChartPayload and readChartData so JSON.parse's implicit any does not leak into callers - OmegaGalaxy.astro: introduce GalaxyProject interface and cast the JSON.parse result, replacing three bare `: any` annotations with inferred types limen task GEN-organvm-portfolio-typing-0626 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chart-loader.ts: Added explicit: unknownreturn types toparseChartPayloadandreadChartDatasoJSON.parse's implicitanydoes not leak through to callersOmegaGalaxy.astro: Introduced aGalaxyProjectinterface for project data parsed from the DOMdata-projectsattribute, replacing three bare: anyannotations with inferred types from the typed castTest plan
npm run typecheck:strict— 0 hints (budget 0, phase W12)vitest run— 279 tests pass, 29 skippednpm run lint:fix— no fixes appliedlimen task GEN-organvm-portfolio-typing-0626
🤖 Generated with Claude Code