Skip to content

Bump conceal to version 2.0.2#238

Open
GabriellCosta wants to merge 1 commit intoorhanobut:masterfrom
GabriellCosta:tigrao/bump_conceal
Open

Bump conceal to version 2.0.2#238
GabriellCosta wants to merge 1 commit intoorhanobut:masterfrom
GabriellCosta:tigrao/bump_conceal

Conversation

@GabriellCosta
Copy link

@GabriellCosta GabriellCosta commented Oct 11, 2019

According to this issue #233, we are not able to be 64 bits eligible, so I update conceal to version 2.0.2

https://github.com/facebook/conceal/releases

Here is the benchmark running on a Nexus 5x API 29

com.orhanobut.benchmark D/HAWK: Hawk.init -> Encryption : NoEncryption
com.orhanobut.benchmark I/System.out: Hawk.init: 38ms
com.orhanobut.benchmark D/HAWK: Hawk.put -> key: key, value: value
com.orhanobut.benchmark D/HAWK: Hawk.put -> Converted to "value"
com.orhanobut.benchmark D/HAWK: Hawk.put -> Encrypted to InZhbHVlIg==
com.orhanobut.benchmark D/HAWK: Hawk.put -> Serialized to java.lang.String##0V@InZhbHVlIg==
com.orhanobut.benchmark D/HAWK: Hawk.put -> Stored successfully
com.orhanobut.benchmark I/System.out: Hawk.put: 11ms
com.orhanobut.benchmark D/HAWK: Hawk.get -> key: key
com.orhanobut.benchmark D/HAWK: Hawk.get -> Fetched from storage : java.lang.String##0V@InZhbHVlIg==
com.orhanobut.benchmark D/HAWK: Hawk.get -> Deserialized
com.orhanobut.benchmark D/HAWK: Hawk.get -> Decrypted to : "value"
com.orhanobut.benchmark D/HAWK: Hawk.get -> Converted to : value
com.orhanobut.benchmark I/System.out: Hawk.get: 5ms
com.orhanobut.benchmark I/System.out: Hawk.count: 0ms
com.orhanobut.benchmark I/System.out: Hawk.count: 0ms
com.orhanobut.benchmark I/System.out: Hawk.count: 4ms

@pedrofsn
Copy link

Please, accept this PR @orhanobut

Copy link

@avneeshkumar1 avneeshkumar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants