Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
「開いて畳む」の後に角をドラッグすると、プレビューは左側の三角形だけを表示する一方、確定後はつながった左右の面が一緒に折れていました。プレビューが候補の先頭1面だけを描き、ドロップ時の接続・破れ判定を使っていなかったことが原因です。
通常の折りが成立する最少枚数を
applyFoldStepで求め、その操作で動く面をすべてプレビューします。表裏それぞれの視点と元の描画高さを保ち、複数メッシュを更新・終了時にまとめて破棄します。通常の折りが成立しない位置には不成立の形を表示せず、特殊折りの選択肢は従来どおりドロップ時に判定します。確認内容:
packages/design-systemのエラー4件で失敗:react-aria-componentsが解決できない2件と、それに伴う暗黙anyの2件。今回の変更箇所での型エラーはありません。