Repository navigation
ci: make the arm orlyc repro dispatch-only, and say what it is for - #558
Merged
Merged
Conversation
) The workflow carried `push: branches: [feat/548-multiarch-image]` because `workflow_dispatch` only works once a workflow exists on the default branch, and the diagnostic had to run before anything merged. That branch merged in #552 and has been deleted, so the trigger now names nothing; the file's own comment said to drop it once the arm question was answered, and #554 answered it. Rewrite the header too. It was written as a one-shot "why does orlyc hang", which is now history rather than instructions. What matters to whoever reads it next is why it is kept: it is the only thing in CI that runs orlyc on arm, and it has to be a RELEASE build, because #554 was an optimiser hoist that -O0 does not reproduce -- 15 pre-fix debug runs were clean while release wedged on the first attempt, 3 out of 3. Still not a gate. #556 tracks whether it should become one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeeping for #556, which it partly resolves.
The dead trigger
orlyc-arm-repro.ymllanded on master in #552 still carrying:That existed for one reason —
workflow_dispatchonly works once a workflow exists on the default branch, and this diagnostic had to run before anything merged. Both halves of that are now gone: the file is on master, and the branch it names was deleted when #552 merged. The file's own comment said to drop it once #548's arm question was answered, and #554 answered it.So: dispatch-only.
The header
Rewritten, because it read as a one-shot "why does
orlychang on aarch64" — a question with an answer now. What the next reader needs is why the file is kept:orlycon arm.make debugandmake testnever touch the embedded mem-sim server, andlang_test.pyis not in the arm job — which is how portability: replace the only x86-specific code with __builtin_prefetch, and ask CI about aarch64 (#548) #550 could report 1753 clean build jobs and 203 passing test binaries on aarch64 while this was broken.-O0does not hoist. 15 pre-fix debug runs were clean while release wedged on the first attempt, 3 out of 3. A debug-build guard would have caught nothing, and the same goes for the next defect of this shape.orly/orlyctarget alone, not the whole tree, so it never pays for the full-tree LTO link.No behaviour change beyond the trigger — same jobs, same matrix, same deadline and stack-dump-on-expiry.
Still not a gate; #556 is where that gets decided.