import_replication.test: interrogate the servers when an RPC deadline expires (#574) - #575
Merged
Merged
Conversation
… expires (#574) The fixture's 240s RPC deadline (#546) fired once on aarch64: the master stopped answering NewFastPrivatePov. The throw then unwound into teardown, which SIGKILLed every server, so the run kept only log tails. Those cannot tell a wedged master from a dead one, or either from a stuck client i/o thread like #537's. TChildServer now keeps a registry of live children. AwaitAnswered, before throwing, prints each child's Describe() and per-thread wchan/syscall (#565's DumpWedge, now split so it also reads /proc/self), plus the test process's own threads. A child that already died reports how, e.g. "killed by signal 11", which settles the question by itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the next occurrence of #574 diagnose itself. Test-only, no engine change.
Why
The fixture's 240s RPC deadline (#546) fired once on aarch64: the master stopped answering
NewFastPrivatePov. The throw unwound into teardown, which SIGKILLed every server, so the run kept only log tails. Those can't tell a wedged master from a dead one, or either from a stuck client i/o thread like #537's. The full reasoning is in #574.What
TChildServerkeeps a registry of live children.AwaitAnsweredthrows, it prints, for each child,Describe()(alive, state [S]orkilled by signal N) and per-threadwchan/syscall. Then it prints the same for the test process's own threads.DumpWedgeis split so the per-thread half (DumpThreads) also reads/proc/self. It staysnoexceptand best-effort.Proven to fire
A throwaway branch forced a 0s deadline on
ImportCoreVector, andci.ymlwas dispatched on it (run 36958768274; branch since deleted). Themake testjob printed:After that, the fixture failed normally and
GracefulShutdownUnresponsiveSlavestill ran and passed.