Bump docker-compose images to latest stable and pin them#54
Merged
Conversation
redis used the floating :latest tag while postgres (:16) and rabbitmq (:4.0.6-management) were pinned to older releases. Floating or stale tags make local infra non-reproducible — a new upstream release can change behaviour (including the healthchecks) on an unrelated day. Update every service to its current latest-stable release and pin it, keeping each image's existing pin granularity: - postgres 16 -> 18 (18.4 latest; major pin, as before) - redis latest -> 8 (8.8.0 latest stable; 8.8-rc1 is a release candidate) - rabbitmq 4.0.6-management -> 4.3.1-management (latest stable patch, keeps the management variant) Note: bumping postgres from 16 to 18 is a major upgrade — an existing postgres_data volume initialised by 16 must be recreated (or migrated with pg_upgrade) before 18 will start. This is fine for ephemeral local dev infra. Closes orochi-network#46
chiro-hiro
force-pushed
the
fix/pin-redis-image
branch
from
4984c3a to
6945f76
Compare
chiro-hiro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #46.
docker-compose.yamlhad inconsistent, partly-stale image tags — redis floated on:latest, while postgres and rabbitmq were pinned to older releases. Floating/stale tags make local infra non-reproducible: a new upstream release can change behaviour (including the healthchecks) on an unrelated day.Per the maintainer note on the issue ("update all base image to latest stable before pin"), this updates every service to its current latest-stable release and pins it, keeping each image's existing pin granularity.
Changes
postgres:16postgres:18redis:latestredis:88.8-rc1is a release candidate, excluded)rabbitmq:4.0.6-managementrabbitmq:4.3.1-management-managementvariantA
postgres_datavolume initialised by postgres 16 will not start on 18 withoutpg_upgradeor recreating the volume. This is fine for ephemeral local dev infra (drop the volume), but anyone with existing local data should plan for it.Verification
docker compose -f docker-compose.yaml config— valid