Skip to content

fix(license): check versions when npm.license is missing - #6

Open
macklinu wants to merge 1 commit into
orta:mainfrom
macklinu:search-versions-for-license
Open

fix(license): check versions when npm.license is missing#6
macklinu wants to merge 1 commit into
orta:mainfrom
macklinu:search-versions-for-license

Conversation

@macklinu

Copy link
Copy Markdown

See #5

I wanted to contribute a fix for #5, but it looks like I'm not mocking node-fetch properly in the tests, and I believe the danger test snapshot changed to the latest danger README (aka it's fetching data from the network in the tests). If you could help out on this, that'd be awesome. I think this is the general fix desired - open to feedback! 😄

@orta

orta commented Sep 12, 2017

Copy link
Copy Markdown
Owner

oh damn, I missed this 👍

@orta

orta commented Sep 12, 2017

Copy link
Copy Markdown
Owner

wanna rebase and we'll get it in?

@glensc

glensc commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

Re-created as #53

it was difficult to rebase because everything that could be done wrong was done with the contribution:

  1. changing unrelated lines
  2. committing everything as a single commit
  3. undescriptive commit messages

@glensc

glensc commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

Also, I don't understand what is the problem that is attempted to fix, the description is not useful to me:

@glensc

glensc commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

Since received zero feedback to re-created pr of this:

closed it.

@glensc

glensc commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

i think this one should be closed too, nobody is interested on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants